Skip to content

Conversation

@ABZhang0
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az grafana api-key

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings June 20, 2025 02:08
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jun 20, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️amg
rule cmd_name rule_message suggest_message
⚠️ 1013 - SubgroupPropAdd grafana api-key sub group grafana api-key added property deprecate_info_target

@azure-client-tools-bot-prd
Copy link

Hi @ABZhang0,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR deprecates the "grafana api-key" command group and updates related documentation to inform users of the change.

  • Modified the command group in commands.py to include deprecation information.
  • Updated help text in _help.py to emphasize the deprecation and provide guidance towards using service accounts.
  • Revised HISTORY.rst to document the deprecation.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/amg/azext_amg/commands.py Added deprecation info to the "grafana api-key" command group.
src/amg/azext_amg/_help.py Updated help messages with new short and long summaries regarding API keys.
src/amg/HISTORY.rst Updated release notes to include the deprecation of API keys.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 20, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Jun 20, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 20, 2025
@yonzhan yonzhan requested review from jsntcy and kairu-ms June 20, 2025 03:48
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jun 23, 2025
@kairu-ms kairu-ms merged commit 5bf5382 into Azure:main Jul 3, 2025
24 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Jul 3, 2025

[Release] Update index.json for extension [ amg-2.7.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=129202636&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot extension/grafana az grafana

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants